New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 9_axis.glade, update axis.tcl #172
Conversation
wrong path indication, all images are not displayed in the skin
@tseufl thanks for your contribution! this commit lacks a "signed-off-by" in the commit message. Please review the documentation about "signed-off-by": http://www.linuxcnc.org/docs/html//code/contributing-to-linuxcnc.html#_signed_off_by_policy In the case of a single commit on its own branch, you can typically add the signed-off-by with "git commit --amend -CHEAD -s" and push it with "git push -f". Besides that, I can't comment on the correctness of the patch. @c-morley can you? Thanks to both of you! |
2016
The glade image path changes look right to me. The current image paths are wrong for both rip and packaged, and this fixes them. However, the problem is present in both master and 2.7. This PR should be rebased to 2.7 and applied there, and merged up to master. |
typo fixing Signed-off-by: Thoren Seufl t_seufl@gmx.de
typo fixing Signed-off-by: Thoren Seufl <t_seufl@gmx.de>
typo fixing Signed-off-by: Thoren Seufl <t_seufl@gmx.de>
typo fixing Signed-off-by: Thoren Seufl <t_seufl@gmx.de>
typo fixing Signed-off-by: Thoren Seufl <t_seufl@gmx.de>
typo fixing added: axis_foam.ini foam cutter Signed-off-by: Thoren Seufl <t_seufl@gmx.de>
@tseufl any idea why github says "unknown repository":
it breaks my normal workflow for fetching PRs locally (or at least I'm guessing the two are related) |
@tseufl Not all commits are signed off, so this is rejected by our git server:
|
I close the open request. |
Feel free to open additional pull requests at any time. Thank you for working to improve linuxcnc. |
wrong path indication, all images are not displayed in the skin
edited: Signed-off-by: Thoren Seufl t_seufl@gmx.de