Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 9_axis.glade, update axis.tcl #172

Closed
wants to merge 9 commits into from
Closed

Update 9_axis.glade, update axis.tcl #172

wants to merge 9 commits into from

Conversation

tseufl
Copy link
Contributor

@tseufl tseufl commented Oct 5, 2016

wrong path indication, all images are not displayed in the skin

edited: Signed-off-by: Thoren Seufl t_seufl@gmx.de

wrong path indication, all images are not displayed in the skin
@jepler
Copy link
Member

jepler commented Oct 6, 2016

@tseufl thanks for your contribution! this commit lacks a "signed-off-by" in the commit message. Please review the documentation about "signed-off-by": http://www.linuxcnc.org/docs/html//code/contributing-to-linuxcnc.html#_signed_off_by_policy

In the case of a single commit on its own branch, you can typically add the signed-off-by with "git commit --amend -CHEAD -s" and push it with "git push -f".

Besides that, I can't comment on the correctness of the patch. @c-morley can you?

Thanks to both of you!

@tseufl tseufl changed the title Update 9_axis.glade Update 9_axis.glade, update axis.tcl Oct 6, 2016
@SebKuzminsky
Copy link
Collaborator

The glade image path changes look right to me. The current image paths are wrong for both rip and packaged, and this fixes them.

However, the problem is present in both master and 2.7. This PR should be rebased to 2.7 and applied there, and merged up to master.

typo fixing

Signed-off-by: Thoren Seufl t_seufl@gmx.de
typo fixing

Signed-off-by: Thoren Seufl <t_seufl@gmx.de>
typo fixing

Signed-off-by: Thoren Seufl <t_seufl@gmx.de>
typo fixing

Signed-off-by: Thoren Seufl <t_seufl@gmx.de>
typo fixing

Signed-off-by: Thoren Seufl <t_seufl@gmx.de>
typo fixing
added: axis_foam.ini        foam cutter 

Signed-off-by: Thoren Seufl <t_seufl@gmx.de>
@jepler
Copy link
Member

jepler commented Oct 14, 2016

@tseufl any idea why github says "unknown repository":

tseufl wants to merge 9 commits into LinuxCNC:master from unknown repository 

it breaks my normal workflow for fetching PRs locally (or at least I'm guessing the two are related)

@jepler
Copy link
Member

jepler commented Oct 14, 2016

@tseufl Not all commits are signed off, so this is rejected by our git server:

remote: The following commits are not signed-off.  By policy, all commits
remote: after October 1, 2014 must be signed-off.  For more information, see
remote: http://git.linuxcnc.org/gitweb?p=linuxcnc.git;a=blob;f=docs/SubmittingPatches
remote: 
remote: [on branch refs/heads/master]
remote: b4623be Update 9_axis.glade
remote: 0958ad7 Update axis.tcl
remote: 4f589c7 Update README

@tseufl
Copy link
Contributor Author

tseufl commented Oct 14, 2016

I close the open request.
Excuse me for the circumstances.

@tseufl tseufl closed this Oct 14, 2016
@jepler
Copy link
Member

jepler commented Oct 15, 2016

Feel free to open additional pull requests at any time. Thank you for working to improve linuxcnc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants